Messages in this thread Patch in this message | | | Date | Wed, 5 Nov 2003 22:10:25 +1100 | Subject | [QUOTA] Drop spin lock when calling request_module | From | Herbert Xu <> |
| |
Hi:
This patch drops the spin lock when calling request_module as the latter will sleep.
Cheers, -- Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ ) Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt Index: kernel-source-2.5/fs/dquot.c =================================================================== RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.5/fs/dquot.c,v retrieving revision 1.3 diff -u -r1.3 dquot.c --- kernel-source-2.5/fs/dquot.c 26 Oct 2003 03:20:37 -0000 1.3 +++ kernel-source-2.5/fs/dquot.c 5 Nov 2003 11:04:30 -0000 @@ -128,17 +128,21 @@ if (!actqf || !try_module_get(actqf->qf_owner)) { int qm; + spin_unlock(&dq_list_lock); + for (qm = 0; module_names[qm].qm_fmt_id && module_names[qm].qm_fmt_id != id; qm++); if (!module_names[qm].qm_fmt_id || request_module(module_names[qm].qm_mod_name)) { actqf = NULL; goto out; } + + spin_lock(&dq_list_lock); for (actqf = quota_formats; actqf && actqf->qf_fmt_id != id; actqf = actqf->qf_next); if (actqf && !try_module_get(actqf->qf_owner)) actqf = NULL; } -out: spin_unlock(&dq_list_lock); +out: return actqf; } | |