Messages in this thread | | | Date | Thu, 9 Oct 2003 07:56:07 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH] Fix mlockall for PROT_NONE mappings |
| |
On 9 Oct 2003, Andi Kleen wrote: > > That is exactly what the patch is doing.
No it's not.
What I'm asking for is a simple
if (vma->vm_flags & VM_READ) make_pages_readable();
kind of thing. A couple of one-liners in the _callers_, not a horribly ugly change way down the stack.
Flags are ugly. Multi-value flags that have magic constants are worse. This patch deserves to die.
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |