lkml.org 
[lkml]   [2003]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix mlockall for PROT_NONE mappings

On 9 Oct 2003, Andi Kleen wrote:
>
> That is exactly what the patch is doing.

No it's not.

What I'm asking for is a simple

if (vma->vm_flags & VM_READ)
make_pages_readable();

kind of thing. A couple of one-liners in the _callers_, not a horribly
ugly change way down the stack.

Flags are ugly. Multi-value flags that have magic constants are worse.
This patch deserves to die.

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-11-18 23:46    [W:0.032 / U:1.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site