lkml.org 
[lkml]   [2003]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] check copy_from_user return value in sony535
	Hi Jens,

Patch against 2.6.0-test6.

- Check the return value of copy_from_user on sony535 CDROM driver.
Found by smatch.

Following the local style, btw :)

Please apply,

Thanks.

Felipe
--- linux-2.6.0-test6/drivers/cdrom/sonycd535.c.orig 2003-10-06 10:46:56.000000000 -0300
+++ linux-2.6.0-test6/drivers/cdrom/sonycd535.c 2003-10-06 10:48:20.000000000 -0300
@@ -1158,7 +1158,8 @@
return err;
spin_up_drive(status);
set_drive_mode(SONY535_AUDIO_DRIVE_MODE, status);
- copy_from_user(params, (void *)arg, 6);
+ if (copy_from_user(params, (void *)arg, 6))
+ return -EFAULT;

/* The parameters are given in int, must be converted */
for (i = 0; i < 3; i++) {
\
 
 \ /
  Last update: 2005-03-22 13:49    [W:3.152 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site