lkml.org 
[lkml]   [2003]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] s390 (6/7): qeth driver.
>  		PRINT_WARN("received an IDX TERMINATE on device %s "
> "with cause code 0x%02x%s\n",
> - card->rdev->dev.bus_id, buffer[4],
> + CARD_BUS_ID(card), buffer[4],
> (buffer[4] ==
> 0x22) ? " -- try another portname" : "");

> #define PROBLEM_TX_TIMEOUT 12
>
> +#define CARD_RDEV(card) card->gdev->cdev[0]
> +#define CARD_WDEV(card) card->gdev->cdev[1]
> +#define CARD_DDEV(card) card->gdev->cdev[2]
> +#define CARD_BUS_ID(card) card->gdev->dev.bus_id
> +#define CARD_RDEV_ID(card) card->gdev->cdev[0]->dev.bus_id
> +#define CARD_WDEV_ID(card) card->gdev->cdev[1]->dev.bus_id
> +#define CARD_DDEV_ID(card) card->gdev->cdev[2]->dev.bus_id

IMHO, this meaningless hiding is poorly concieved and
was discredited by its usage in UNIX. I object. On paper
is sounds fine, allowing to change implementation details
underneath the macro, yada yada. In practice, it adds
unnecessary opaquity.

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:49    [W:1.016 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site