Messages in this thread | | | Subject | Re: [Linux-fbdev-devel] Re: FBDEV 2.6.0-test7 updates. | From | Michel Dänzer <> | Date | Thu, 16 Oct 2003 02:24:56 +0200 |
| |
On Thu, 2003-10-16 at 01:20, Andrew Morton wrote: > > This one comes up again and again. What should we do with it? > > > --- 25/drivers/video/radeonfb.c~radeonfb-line_length-fix 2003-10-05 09:17:58.000000000 -0700 > +++ 25-akpm/drivers/video/radeonfb.c 2003-10-05 09:17:58.000000000 -0700 > @@ -2090,7 +2090,7 @@ static int radeonfb_set_par (struct fb_i > > } > /* Update fix */ > - info->fix.line_length = rinfo->pitch*64; > + info->fix.line_length = mode->xres_virtual*(mode->bits_per_pixel/8); > info->fix.visual = rinfo->depth == 8 ? FB_VISUAL_PSEUDOCOLOR : FB_VISUAL_DIRECTCOLOR; > > #ifdef CONFIG_BOOTX_TEXT
I'd say drop it, as it's wrong. :) It's like this in Ben's tree:
/* Update fix */ if (accel) info->fix.line_length = rinfo->pitch*64; else info->fix.line_length = mode->xres_virtual * ((mode->bits_per_pixel + 1) / 8);
-- Earthling Michel Dänzer \ Debian (powerpc), XFree86 and DRI developer Software libre enthusiast \ http://svcs.affero.net/rm.php?r=daenzer
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |