Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Date | Wed, 15 Oct 2003 16:17:05 -0700 | From | Andrew Morton <> | Subject | Re: FBDEV 2.6.0-test7 updates. |
| |
James Simmons <jsimmons@infradead.org> wrote: > > Here is the latest fbdev patches. Please test!!! Many new enhancements. > Several fixes. The patch is against 2.6.0-test7 > > http://phoenix.infradead.org/~jsimmons/fbdev.diff.gz
Cool. I've had the below fix floating about for a while. Is it still relevant?
From: Chris Heath <chris@heathens.co.nz>
I am still seeing a lot of cursors being left behind. It is not a race condition or anything -- in the TTY line editor, it happens about 50% of the time when you press backspace.
What appears to be happening is the cursor is flashing twice as slowly as the driver thinks it is, so of course it's wrong half the time when it comes to erase the cursor.
The patch below fixes it for me.
drivers/video/softcursor.c | 6 ++++++ 1 files changed, 6 insertions(+)
diff -puN drivers/video/softcursor.c~cursor-flashing-fix drivers/video/softcursor.c --- 25/drivers/video/softcursor.c~cursor-flashing-fix 2003-08-16 14:01:15.000000000 -0700 +++ 25-akpm/drivers/video/softcursor.c 2003-08-16 14:01:15.000000000 -0700 @@ -74,6 +74,12 @@ int soft_cursor(struct fb_info *info, st if (info->cursor.image.data) info->fbops->fb_imageblit(info, &info->cursor.image); + + if (!info->cursor.enable) { + for (i = 0; i < size; i++) + dst[i] ^= info->cursor.mask[i]; + } + return 0; } _
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |