Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Date | Thu, 9 Jan 2003 22:58:21 +0100 | From | Petr Vandrovec <> | Subject | [PATCH] kallsyms prints wrong symbol names |
| |
Hi Linus,
Since stem compression arrived to kallsyms table, we are printing name of symbol BEFORE one we want to print (and empty string for first symbol) because of we return buffer with copy of last name we skipped instead of 'name' variable as we did before. So one more pass through loop is required.
Without this patch my stack traces were really strange...
Thanks, Petr Vandrovec vandrove@vc.cvut.cz
--- linux-2.5.55/kernel/kallsyms.c 2003-01-09 22:47:40.000000000 +0100 +++ linux-2.5.55/kernel/kallsyms.c 2003-01-09 22:38:01.000000000 +0100 @@ -46,7 +46,7 @@ } /* Grab name */ - for (i = 0; i < best; i++) { + for (i = 0; i < best + 1; i++) { unsigned prefix = *name++; strncpy(namebuf + prefix, name, 127 - prefix); name += strlen(name) + 1; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |