Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [RFC] irq handling code consolidation, second try (v850 part) | From | Miles Bader <> | Date | 04 Jan 2003 22:00:29 +0900 |
| |
Can't test it, but the v850 part looks great, ah, it's lovely to see all that code being deleted...
One comment: `arch_check_irq' is a bad name, it doesn't make it at all clear what it does.
I might suggest inverting the sense, and using `irq_valid' -- the `arch_' prefix seems unnecessary (as with `irq_desc') since it's not a arch-specific version of a more general wrapper.
Thanks,
-Miles
-- Quidquid latine dictum sit, altum viditur. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |