Messages in this thread Patch in this message | | | Date | Mon, 27 Jan 2003 21:57:43 +0100 (MET) | From | Mikael Pettersson <> | Subject | Re: Dell Latitude CPi keyboard problems since 2.5.42 |
| |
On Mon, 27 Jan 2003 13:34:32 +0100, Vojtech Pavlik wrote: >> Either removing the SSCANSET from atkbd_cleanup(), or changing >> atkbd->oldset from 22 to 2, solves my CPi's keyboard problems. > >Can you try with the attached atkbd.c? It uses RESET_BAT instead of >SSCANSET, which will slow down the reboot a bit, but should be very safe >to bring the keyboard to its power-on state, which the BIOS should be >able to handle.
I tried it, and the change to use RESET_BAT in atkbd_cleanup() works fine. Tested on my Dell Latitiude CPi and four desktop boxes of various vintages. No new problems. A reboot takes maybe 1/10 of a second longer, but I don't care.
However, your version of atkbd.c caused a linkage error due to a reference to input_regs() in atkbd_interrupt(). I extracted just the changes to atkbd_cleanup() and atkbd_command(), but that left me with a dead keyboard on the first test box. In the end I kept only the atkbd_cleanup() change and the increased timeout for RESET_BAT in atkbd_command() [see below].
/Mikael
--- linux-2.5.59/drivers/input/keyboard/atkbd.c.~1~ 2002-11-23 17:59:41.000000000 +0100 +++ linux-2.5.59/drivers/input/keyboard/atkbd.c 2003-01-27 19:54:30.000000000 +0100 @@ -233,6 +233,9 @@ int i; atkbd->cmdcnt = receive; + + if (command == ATKBD_CMD_RESET_BAT) + timeout = 200000; /* 2 sec */ if (command & 0xff) if (atkbd_sendbyte(atkbd, command & 0xff)) @@ -442,7 +445,7 @@ static void atkbd_cleanup(struct serio *serio) { struct atkbd *atkbd = serio->private; - atkbd_command(atkbd, &atkbd->oldset, ATKBD_CMD_SSCANSET); + atkbd_command(atkbd, NULL, ATKBD_CMD_RESET_BAT); } /* - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |