Messages in this thread | | | From | Andries.Brouwer@cwi ... | Date | Fri, 10 Jan 2003 14:08:53 +0100 (MET) | Subject | sd_read_cache_type |
| |
Last year I wrote half a dozen drivers for various USB card readers. Some don't work anymore with 2.5.recent. I just investigated one. The reason it stopped working is the sd_read_cache_type() call added in 2.5.41. (With that call removed it works again.)
Will look a bit more at the details later. For now a question: this call does a MODE_SENSE with the DBD (disable block descriptors) bit set. Is there a reason for that? Wouldn't the same code work in the same way without that bit?
And the reason I ask is that we already have sd_do_mode_sense6(), so part of sd_read_cache_type() can be simply replaced by a call of sd_do_mode_sense6(), but the latter needs an extra parameter if DBD is really needed.
And a second question: sd_read_cache_type() is called also when no medium is present. Objections against only calling when media are present?
Andries - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |