Messages in this thread | | | Subject | Re: 2.3.39 compile errors on Alpha | From | Alan Cox <> | Date | 30 Sep 2002 13:35:40 +0100 |
| |
On Mon, 2002-09-30 at 12:08, Adrian Bunk wrote: > this is a known issue, the following patch (already in Linus' BK tree) > fixes it: > > --- linux-2.5.35-VIRGIN/drivers/atm/atmtcp.c 2002-08-24 00:08:21.000000000 -0700 > +++ linux-2.5.35/drivers/atm/atmtcp.c 2002-09-16 21:04:30.000000000 -0700 > @@ -275,7 +275,7 @@ > result = -ENOBUFS; > goto done; > } > - new_skb->stamp = xtime; > + do_gettimeofday(&new_skb->stamp);
Is this actually safe - suppose the machine has no tsc counter (eg old x86 or indeed new x86 numa, speedstep using, etc). In that case do_gettimeofday doesn't appear to be either IRQ safe or fast enough to use in this way ?
Alan
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |