lkml.org 
[lkml]   [2002]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: 2.3.39 compile errors on Alpha
From
Date
On Mon, 2002-09-30 at 12:08, Adrian Bunk wrote:
> this is a known issue, the following patch (already in Linus' BK tree)
> fixes it:
>
> --- linux-2.5.35-VIRGIN/drivers/atm/atmtcp.c 2002-08-24 00:08:21.000000000 -0700
> +++ linux-2.5.35/drivers/atm/atmtcp.c 2002-09-16 21:04:30.000000000 -0700
> @@ -275,7 +275,7 @@
> result = -ENOBUFS;
> goto done;
> }
> - new_skb->stamp = xtime;
> + do_gettimeofday(&new_skb->stamp);

Is this actually safe - suppose the machine has no tsc counter (eg old
x86 or indeed new x86 numa, speedstep using, etc). In that case
do_gettimeofday doesn't appear to be either IRQ safe or fast enough to
use in this way ?

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:29    [W:0.118 / U:0.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site