Messages in this thread | | | From | David Woodhouse <> | Subject | Re: [PATCH]: linux-2.5.30uc0 MMU-less patches | Date | Fri, 02 Aug 2002 15:39:56 +0100 |
| |
gerg@snapgear.com said: > I have coded a generic MTD map driver to replace the old crufty > blkmem driver. The blkmem driver will be going away in future patches.
--- linux-2.5.30/drivers/mtd/maps/snapgear-uc.c Thu Jan 1 10:00:00 1970 +++ linux-2.5.30uc0/drivers/mtd/maps/snapgear-uc.c Mon Jul 15 21:29:25 2002 +#ifdef CONFIG_NFTL +#include <linux/mtd/nftl.h> +#endif
You shouldn't need that.
+int flash_eraseconfig(void) +{
This will cause an oops if it gets woken by a signal -- you leave and the the 'struct erase_info' on your stack frame, which you passed to the asynchronous erase call, goes bye bye.
+ ROOT_DEV = MKDEV(NFTL_MAJOR, 1);
Oh, I see -- if we fail to find a file system we recognise on the NOR flash, try booting from DiskOnChip. Does this really live here?
--- linux-2.5.30/drivers/mtd/mtdblock.c Fri Aug 2 15:15:41 2002 +++ linux-2.5.30uc0/drivers/mtd/mtdblock.c Fri Aug 2 16:00:13 2002 - if (req->flags & REQ_CMD) + if (! (req->flags & REQ_CMD))
Yes.
+#ifdef MAGIC_ROM_PTR +static int +mtdblock_romptr(kdev_t dev, struct vm_area_struct * vma)
No, although the fix I'm happy with is going to take a while to get implemented so maybe in the short term. This is likely to get rejected on other grounds anyway; perhaps separate it and don't submit it for inclusion just now?
-- dwmw2
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |