Messages in this thread Patch in this message | | | Date | Tue, 13 Aug 2002 01:49:33 -0700 | From | Andrew Morton <> | Subject | Re: [patch] __func__ -> __FUNCTION__ |
| |
Christoph Hellwig wrote: > > On Mon, Aug 12, 2002 at 11:17:03PM -0700, Andrew Morton wrote: > > > > It is a requirement of the SPARC port that Linux be compilable > > by egcs-1.1.2, aka gcc-2.91.66. > > > > That compiler does not support __func__. > > Is there any reason to not use __FUNCTION__? According to the gcc folks > that there is no plan to retire it, and as long as all known-good kernel > compilers support it a gccism is a lot better than a standard feature that > is not supported by most of the kernel compilers.
Sounds fine to me.
--- linux-2.5.31/include/linux/kernel.h Wed Jul 24 14:31:31 2002 +++ 25/include/linux/kernel.h Tue Aug 13 01:48:36 2002 @@ -13,6 +13,8 @@ #include <linux/types.h> #include <linux/compiler.h> +#define __func__ use.__FUNCTION__.not.__func__ + /* Optimization barrier */ /* The "volatile" is due to gcc bugs */ #define barrier() __asm__ __volatile__("": : :"memory") It affects
drivers/char/drm/mga_dma.c drivers/char/drm/mga_drv.h drivers/char/drm/mga_state.c drivers/char/drm/r128_cce.c drivers/char/drm/r128_drv.h drivers/char/drm/r128_state.c drivers/char/drm/radeon_cp.c drivers/char/drm/radeon_drv.h drivers/char/drm/radeon_state.c include/net/bluetooth/bluetooth.h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |