Messages in this thread | | | Date | Tue, 18 Jun 2002 16:12:42 +0200 | Subject | Re: small 5575 PCI ATM fix | From | Petter <> |
| |
On Tue, Jun 18, 2002 at 03:58:37PM +0200, Dave Jones wrote: > On Tue, Jun 18, 2002 at 03:35:27PM +0200, Petter wrote: > Error handling in that driver seems to be 'creative' at best.
I agree.
> No releasing of already allocated resources, just returning -EAGAIN > everywhere, and no checking for already allocated resources. > > Someone with too much time on their hands[1] could probably clean this > up to free allocated resources on failure and return -ENOMEM on > allocation failures.
Yup, but I do not have that much spare time ;) I just looked at the code for two seconds and thought that I'd send a quick fix for it.
Regards
Petter Wahlman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |