Messages in this thread | | | Date | Tue, 18 Jun 2002 15:58:37 +0200 | From | Dave Jones <> | Subject | Re: small 5575 PCI ATM fix |
| |
On Tue, Jun 18, 2002 at 03:35:27PM +0200, Petter wrote: > > I was grepping through some code, and noticed that the return value > of a kmalloc in iphase.c was not checked. > A patch was sendt to the author, but this was the reply I got: > > "Peter Wang is no longer a member of the Interphase team. Interphase > does support the 5575 PCI ATM adapter with Linux, but for driver enhancements > and fixes, we require a current software warranty contract. If you > could send me the serial number and / or the MAC address of your adapter, I > can verify your warranty status and have the latest driver sent to you."
rofl. 8-)
> I do not care about their driver since I do not have an ATM card, but > the current driver should anyhow be fixed.
Error handling in that driver seems to be 'creative' at best. No releasing of already allocated resources, just returning -EAGAIN everywhere, and no checking for already allocated resources.
Someone with too much time on their hands[1] could probably clean this up to free allocated resources on failure and return -ENOMEM on allocation failures.
Dave
[1] or a 'software warranty contract'.
-- | Dave Jones. http://www.codemonkey.org.uk | SuSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |