Messages in this thread | | | Date | Tue, 19 Feb 2002 16:53:26 -0500 | From | Pete Zaitcev <> | Subject | Re: ENOTTY from ext3 code? |
| |
> ext3/ioctl.c: > ... > return -ENOTTY; > > Does it really make sense to return "not a typewriter" from ext3 > ioctl?
Absolutely. In fact, it's a pet pieve of mine. Lots and lots of clueless driver writes return -EINVAL in such cases, and I keep cleaning it up. The problem with EINVAL is that it makes it harder to diagnose any problems that can come up.
Also, recent strerror() returns "Inappropriate ioctl for a device", if that is your concern. Personally, I think "Not a typewriter" was a warmer and fuzzier reference to the roots, but oh well... Dennis giveth, TOG taketh away...
-- Pete - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |