Messages in this thread | | | Subject | Re: [PATCH] Summit support for 2.5 - now with subarch! [4/5] | Date | Mon, 14 Oct 2002 16:11:09 -0700 | From | James Bottomley <> |
| |
> + summit_check(oem, str);
This is more a type check hook. Since it might potentially be used to catch other machine types, shouldn't it have a more generic name (mptable_string_hook or something)?
> +int summit_x86 = 0;
This should really be in a .c file in mach-summit. I know a single line file with just a variable in it is a bit strange, but the principle of the subarch stuff is to have anything subarch specific (which this is) in mach-<subarch>.
James
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |