Messages in this thread | | | Subject | Re: [PATCH]: 2.5.1pre9 change several if (x) BUG to BUG_ON(x) | From | Momchil Velikov <> | Date | 06 Jan 2002 16:48:46 +0200 |
| |
>>>>> "Alan" == Alan Cox <alan@lxorguk.ukuu.org.uk> writes:
>> Yes, only that, even a trained monkey is able to make this patch, but i think >> is a good way to make people confortable with BUG_ON
Alan> Your patch looks wrong (ook ook! 8)) - if you build without BUG enabled you Alan> don't make various function calls with your change. BUG_ON has the C nasty Alan> assert() does that makes it a horrible horrible idea and its unfortunate Alan> it got put in.
Alan> BUG_ON(function(x,y))
#ifdef DEBUG #define BUG_ON(x) if (x) BUG() #else #define BUG_ON(x) (void)(x) #endif - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |