Messages in this thread | | | Subject | Re: [PATCH]: 2.5.1pre9 change several if (x) BUG to BUG_ON(x) | Date | Sun, 6 Jan 2002 14:48:13 +0000 (GMT) | From | Alan Cox <> |
| |
> Yes, only that, even a trained monkey is able to make this patch, but i think > is a good way to make people confortable with BUG_ON
Your patch looks wrong (ook ook! 8)) - if you build without BUG enabled you don't make various function calls with your change. BUG_ON has the C nasty assert() does that makes it a horrible horrible idea and its unfortunate it got put in.
BUG_ON(function(x,y))
ends up not causing function to be called when not debugging
The classic C mess people get into is similar with things like
assert(x++ == 4);
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |