Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Khalid Aziz <> | Subject | [PATCH] SCSI command bytes are copied twice | Date | Wed, 18 Apr 2001 16:11:04 -0600 (MDT) |
| |
SCSI subsystem needs to copy the SCSI command bytes into a Scsi_Request structure for a SCSI command being issued by one of the higher level drivers before it queues the command up. It does this copy twice. Even though this will cause no more than 12 bytes to be copied twice, this code is still invoked frequently enough to justify not incurring the overhead of a redundant copy. Following patch should fix this.
Thanks, Khalid
==================================================================== Khalid Aziz Linux Development Laboratory (970)898-9214 Hewlett-Packard khalid@fc.hp.com Fort Collins, CO
--- linux-2.4.3-orig/drivers/scsi/scsi.c Fri Feb 9 12:30:23 2001 +++ linux-2.4.3/drivers/scsi/scsi.c Wed Apr 18 14:22:00 2001 @@ -832,9 +832,6 @@ SRpnt->sr_allowed = retries; SRpnt->sr_done = done; SRpnt->sr_timeout_per_command = timeout; - - memcpy((void *) SRpnt->sr_cmnd, (const void *) cmnd, - sizeof(SRpnt->sr_cmnd)); if (SRpnt->sr_cmd_len == 0) SRpnt->sr_cmd_len = COMMAND_SIZE(SRpnt->sr_cmnd[0]); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |