Messages in this thread | | | Subject | Re: [PATCH] Updated Olympic Driver | From | mike_phillips@urscorp ... | Date | Wed, 18 Apr 2001 12:29:35 -0400 |
| |
Jeff,
Thanks for the comments. This patch has been hanging too long already, the drivers should be updated as given and I'll work up all the fixes and another patch.
>> + sisr=readl(olympic_mmio+SISR_RR) ; /* Read & Reset sisr */
> you should also check for 0xFFFFFFFF, which will happen if the hardware > disappears...
We catch it in the Adapter Check and gracefully exit.
>> struct olympic_tx_status olympic_tx_status_ring[OLYMPIC_TX_RING_SIZE];
> With PCI DMA you (theoretically) never pass any members of your private > struct directly to the chip. thus, either your comment or code is > wrong...
On the cards to completely remove these structures from the private struct and allocate them in the driver.
All other comments will be incorporated.
Mike
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |