Messages in this thread Patch in this message | | | Date | Tue, 6 Mar 2001 15:28:47 +0300 | From | Andrey Panin <> | Subject | [PATCH] bug in /drivers/char/epca.c |
| |
Hi all,
this patch fixes bug in Digi epca.c driver. This driver calls tty_register_driver() 3 times and tty_unregister_driver() 2 times. This bug causes hang on module unload.
Also a question: somebody knows why this driver scans PCI devices before registering tty drivers? It makes impossible to remove panic() calls easily.
Best regards.
-- Andrey Panin | Embedded systems software engineer pazke@orbita1.ru | PGP key: http://www.orbita1.ru/~pazke/AndreyPanin.ascdiff -ur linux.vanilla/drivers/char/epca.c linux/drivers/char/epca.c --- linux.vanilla/drivers/char/epca.c Mon Mar 5 12:01:51 2001 +++ linux/drivers/char/epca.c Tue Mar 6 13:37:58 2001 @@ -1574,7 +1574,8 @@ cli(); if ((tty_unregister_driver(&pc_driver)) || - (tty_unregister_driver(&pc_callout))) + (tty_unregister_driver(&pc_callout)) || + (tty_unregister_driver(&pc_info))) { printk(KERN_WARNING "<Error> - DIGI : cleanup_module failed to un-register tty driver\n"); restore_flags(flags);[unhandled content-type:application/pgp-signature]
| |