Messages in this thread | | | Date | Fri, 16 Mar 2001 00:32:56 -0500 (EST) | From | Alexander Viro <> | Subject | Re: [OOPS] report |
| |
On Fri, 16 Mar 2001, Chris Mason wrote:
> > ObReiserfs_panic: what the hell is that ->s_lock bit about? panic() > > _never_ tries to do any block IO. It looks like a rudiment of something > > that hadn't been there for 5 years, if not longer. The same goes for > > ext2_panic() and ufs_panic(), BTW... I would suggest crapectomey here. > > Ugh, that should have been dragged out and shot...patch will come in the AM. > Unfortunately it's nastier than I thought. panic() does sys_sync(). And IMO it really shouldn't. Notice that ->s_lock doesn't prevent ->write_inode() and friends from being called.
I suspect that the right fix is to drop the ->s_lock bogosity along with sys_sync() call in panic()...
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |