Messages in this thread | | | Date | Fri, 16 Mar 2001 01:03:20 -0500 (EST) | From | Alexander Viro <> | Subject | Re: [OOPS] report |
| |
On Fri, 16 Mar 2001, Chris Mason wrote:
> > I suspect that the right fix is to drop the ->s_lock bogosity along with > > sys_sync() call in panic()... > > Ok, I was more talking about the ugliness that is reiserfs_panic (how many > times do we need a commented out for(;;)?). For panic() calling sys_sync, > I think there non-filesystem related panics where we do want to sync.
panic doesn't sync if called from interrupt (thanks $DEITY). It is pointless to sync during boot. sync from driver panic is not better than one from fs.
What does it leave? I hadn't checked each panic(), but it seems that if we ever want syncing upon panic() it's safer to do sys_sync() by hands before calling panic(). If it is actually ever needed, that is.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |