Messages in this thread | | | From | "Adam J. Richter" <> | Date | Sat, 1 Jul 2000 00:48:25 -0700 | Subject | static modules_{init,exit} functions in pre3-2 |
| |
linux-2.4.0test3-pre2 adds "-Werror" to the default C compiler flags, which is forcing the elimination of lots of unused variables and functions, which I think is great. It also is causing compilations of modules to abort if their module_{init,exit} functions are declared static. I guess that at least in the case of the initialization functions, making them global will encourage people to use the same initialization functions for the modular and non-modular cases, which will improve maintainability.
Anyhow, I am happy to submit patches to make these declarations non-static as I come across them, but I would like to get confirmation that this is the intention before I submit a bunch of unwanted patches (an alternative, for example, would be to somehow redefine module_{init,exit} to add a reference to the function that would appease gcc).
Adam J. Richter __ ______________ 4880 Stevens Creek Blvd, Suite 104 adam@yggdrasil.com \ / San Jose, California 95129-1034 +1 408 261-6630 | g g d r a s i l United States of America fax +1 408 261-6631 "Free Software For The Rest Of Us."
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |