Messages in this thread Patch in this message | | | From | Andrzej Krzysztofowicz <> | Subject | Re: 2.3.4[89] fail to probe/id IDE properly (long) | Date | Tue, 7 Mar 2000 17:50:10 +0100 (MET) |
| |
> Wouldn't it make more sense to separate it into separate chunks > i.e. CONFIG_NET_PCI, CONFIG_NET_EISA, CONFIG_NET_VLB, CONFIG_NET_ONBOARD > and *then* check for CONFIG_PCI before offering CONFIG_NET_PCI? > > Or maybe I'm just completely clueless.
The suggested solution breaks parser (xconfig). Xconfig "by design" does not accept duplicated config options. This has also another disadvantage: if you configure for both EISA and PCI you are asked some questions twice, eg:
> + tristate ' Generic DECchip & DIGITAL EtherWORKS EISA' CONFIG_DE4X5
> + tristate ' Generic DECchip & DIGITAL EtherWORKS PCI' CONFIG_DE4X5
How the common driver should be compiled if you answer "y" to the first and "m" (or even "n") to the second ?
IMHO, it should be enough (and be a good way) to make dependent on CONFIG_PCI just the drivers which support *ONLY* PCI cards, eg: Tulip, PCI NE2000, RTL-8139...
BTW, notice that it cannot be done with dep_{bool,tristate} function as CONFIG_PCI may be not defined for some architectures.
Regards Andrzej
> ------------------------------------------------------------------------ > --- Config.in Thu Mar 2 07:30:43 2000 > +++ Config.in.new Tue Mar 7 09:46:26 2000 > @@ -119,21 +119,31 @@ > tristate ' SKnet MCA support' CONFIG_SKMC > tristate ' NE/2 (ne2000 MCA version) support' CONFIG_NE2_MCA > fi > - bool ' EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI > - if [ "$CONFIG_NET_PCI" =3D "y" ]; then > - tristate ' AMD PCnet32 (VLB and PCI) support' CONFIG_PCNET32 > - if [ "$CONFIG_EXPERIMENTAL" =3D "y" ]; then > - tristate ' Adaptec Starfire support (EXPERIMENTAL)' CONFIG_ADAPTEC_ST= > ARFIRE > - fi > + bool ' Other EISA cards' CONFIG_NET_EISA > + if [ "$CONFIG_NET_EISA" =3D "y" ]; then > if [ "$CONFIG_EXPERIMENTAL" =3D "y" ]; then > tristate ' Ansel Communications EISA 3200 support (EXPERIMENTAL)' CON= > FIG_AC3200 > fi > etc.
-- ======================================================================= Andrzej M. Krzysztofowicz ankry@mif.pg.gda.pl phone (48)(58) 347 14 61 Faculty of Applied Phys. & Math., Technical University of Gdansk
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |