Messages in this thread | | | Date | Fri, 06 Oct 2000 11:06:40 -0400 | From | Douglas Gilbert <> | Subject | Re: [PATCH] 2nd go for scsi upper layers + I2O |
| |
Torben Mathiasen wrote:
> Ok this patch should be diffed correctly. Same things apply: > > apply patch > copy sd.c st.c sg.c sr.c sr_ioctl.c sr_vendor.c from > drivers/scsi to drivers/scsi/upper > > The EXPORT_SYMBOL has been removed as Jeff suggested. > > TLAN will hopefully follow soon.....
[snipped most of patch, see lkml]
> +sg_mod.o: $(sg_mod-objs) > + $(LD) -r -o $@ $(sg_mod-objs)
Firstly, I just spent 2 months trying to get the sd module name reverted to "sd_mod.o" as it is in lk 2.2 and 2.0 .Now this patch seems to rename the sg module to "sg_mod.o"! Since the vast majority of distributions build sg as a module, there could be a lot of irate SANE and cdrecord users out there. Also devfsd and other module loading software would need to be changed. Hopefully this is an oversight.
Secondly, do we really need the scsi Makefile and directory structure changed this close to the lk 2.4 release? What does it gain us? Could changes of this dimension be sent to Eric Youngdale or at least the linux-scsi list rather than just sent to the linux-kernel list?
Doug Gilbert - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
| |