Messages in this thread Patch in this message | | | Date | Sat, 24 Apr 1999 22:14:16 +0200 | From | Stanislav Brabec <> | Subject | small fixes to isofs |
| |
Hallo kernel developers
I found small trouble in isofs: When evaluating mount option "mode", the argument was expected as decimal number for default. But convention for file flags is octal.
Second trouble is in documentation (linux/Documentation/filesystems/isofs.txt): umask=nnn The permission mask (see umask(1)) for the partition. This seem not to be true and mount option was renamed to "mode", and it is documented few lines below in the same document.
-- Stanislav Brabec
----------------- cut here --------------------- --- linux/fs/isofs/inode.c.orig Tue Dec 29 20:40:35 1998 +++ linux/fs/isofs/inode.c Fri Apr 23 17:56:25 1999 @@ -355,9 +355,14 @@ else if (!strcmp(value,"auto")) ; else return 0; } + else if (value && !strcmp(this_char,"mode")) { + char * vpnt = value; + unsigned int ivalue = simple_strtoul(vpnt, &vpnt, 8); + if (*vpnt) return 0; + popt->mode = ivalue; + } else if (value && (!strcmp(this_char,"block") || - !strcmp(this_char,"mode") || !strcmp(this_char,"uid") || !strcmp(this_char,"gid"))) { char * vpnt = value; @@ -376,9 +381,6 @@ case 'g': popt->gid = ivalue; break; - case 'm': - popt->mode = ivalue; - break; } } else return 1; --- linux/Documentation/filesystems/isofs.txt.orig Wed Jun 24 23:30:07 1998 +++ linux/Documentation/filesystems/isofs.txt Sat Apr 24 22:07:54 1999 @@ -2,7 +2,6 @@ gid=nnn All files in the partition will be in group nnn. uid=nnn All files in the partition will be owned by user id nnn. - umask=nnn The permission mask (see umask(1)) for the partition. Mount options that are the same as vfat partitions. These are only useful when using discs encoded using Microsoft's Joliet extensions. ----------------- cut here ---------------------
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |