lkml.org 
[lkml]   [1999]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: ioremap(), bus_to_virt() and PCI devices on different Linux archi
Date
Sorry to disturb you again guys, my previous e-mail contained
a factual error:

> For example Russell King's cyber2000fb.c contains this code:
>
> int __init cyber2000fb_init(void)
> {
>
> CyberRegs = bus_to_virt(dev->base_address[0]) + 0x00800000;/*FIXME*/
> }
>
> This is wrong. ioremap() must be used instead (and the
> driver must be updated to use dev->resource[0].start).
> Perhaps ioremap() does not work properly on arm.

Russell contacted me and provided a corrective information.

The kernel which I used is somewhat out of date,
Linux 2.3.23 contains a correct code, with ioremap().
Also, on the date the code above was written, ioremap() was
not present in the arm architecture, so it could not be used.

I mentioned cyber2000fb.c because I considered it for a JavaStation
to replace igafb.c, as rmk's driver is way superior to the one we use.

Sorry for the misinformation,
--Pete

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:54    [W:0.062 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site