Messages in this thread Patch in this message | | | Date | Fri, 1 Oct 1999 18:16:24 +0200 | From | Pavel Machek <> | Subject | Re: [linux-usb] Audio update of today (thursday) |
| |
Hi!
> Again against 2.3.18ac10. > > This time: > > - try harder to sensibly guess which OSS mixer > channel to use for a certain mixer unit > - mixer now does stereo correctly > > I'm actually able to play back something using OHCI-HCD, > the problem now is that the PC locks up when stopping the > sound.
Well, it does not lock for me. It _still_ prints that 'invalid synch pipe' message.
Values are like this at that time:
alts->bNumEndpoints = 2, alts->endpoint[1].bmAttributes = 1, alts->endpoint[1].bSynchAddress = 0, alts->endpoint[1].bEndpointAddress = 130,
> UHCI won't work for certain until the fixup_isoc stuff > is in.
Do you mean this two-liner? Or what fix should I get?
--- clean/drivers/usb/uhci.c Sat Sep 11 20:56:02 1999 +++ linux/drivers/usb/uhci.c Fri Oct 1 17:54:11 1999 @@ -935,7 +971,7 @@ td->status |= TD_CTRL_IOC; td->completed = isocdesc->callback_fn; cb_frames = 0; - uhci_add_irq_list (dev->uhci, td, isocdesc->callback_fn, isocdesc->context); + uhci_add_irq_list (dev->uhci, td, isocdesc->callback_fn, isocdesc); } bufptr += fd->frame_length; /* or isocdesc->frame_size; */ @@ -955,7 +991,7 @@ if (!(td->status & TD_CTRL_IOC)) { td->status |= TD_CTRL_IOC; td->completed = isocdesc->callback_fn; - uhci_add_irq_list(dev->uhci, td, isocdesc->callback_fn, isocdesc->context); /* TBD: D.K. ??? */ + uhci_add_irq_list(dev->uhci, td, isocdesc->callback_fn, isocdesc); /* TBD: D.K. ??? */ } return 0; } /* end uhci_run_isoc */
-- I'm really pavel@ucw.cz. Look at http://195.113.31.123/~pavel. Pavel Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |