Messages in this thread Patch in this message | | | Date | Thu, 14 Jan 1999 02:05:50 -0500 (EST) | From | "Theodore Y. Ts'o" <> | Subject | Re: BUG LIST: 2.2.0pre7 |
| |
Date: Wed, 13 Jan 1999 20:41:51 -0600 (CST) From: "Robert B. Hamilton" <rbh041a@unix.tamu.edu>
Also the serial divide by zero is still there... vis, setserial /dev/ttyS0 baud_base 1200 setserial /dev/ttyS0 baud_base 1200 (eg do it twice)
This only happens when users don't understand what baud_base means, but I suppose we should appropriately bullet proof the driver against even really stupid users.... Linus, could you please apply this patch to the serial driver?
- Ted
Patch generated: on Thu Jan 14 02:03:54 EST 1999 by tytso@rsts-11.mit.edu against Linux version 2.2.0-pre7 =================================================================== RCS file: drivers/char/RCS/serial.c,v retrieving revision 1.1 diff -u -r1.1 drivers/char/serial.c --- drivers/char/serial.c 1999/01/14 06:58:05 1.1 +++ drivers/char/serial.c 1999/01/14 07:03:51 @@ -1681,7 +1681,7 @@ new_serial.irq = irq_cannonicalize(new_serial.irq); if ((new_serial.irq >= NR_IRQS) || (new_serial.port > 0xffff) || - (new_serial.baud_base == 0) || (new_serial.type < PORT_UNKNOWN) || + (new_serial.baud_base < 9600)|| (new_serial.type < PORT_UNKNOWN) || (new_serial.type > PORT_MAX) || (new_serial.type == PORT_CIRRUS) || (new_serial.type == PORT_STARTECH)) { return -EINVAL;
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |