Messages in this thread Patch in this message | | | Date | Mon, 23 Mar 1998 05:12:12 +0300 | From | Itai Nahshon <> | Subject | [PATCH] Reversed stereo fix |
| |
This surely addresses the reversed stereo problem. I never got into this area in the sound driver before taking this challenge. I'll be happy if it gets tested in other configuration before it gets into the kernel (the problem was there in kernels 2.1.41 through 2.1.90... two more weeks wouln't hurt much).
Note: kernel 2.1.90 introduces some new sound problems. I experienced some ticking sound what playing sounds using memory mapped interface. There's also the problem of Opps when unloading the sound driver. I do not have fixes for these problems.
Itai -- Itai Nahshon nahshon@actcom.co.il Also nahshon@vnet.ibm.com--- linux/drivers/sound/audio.c.old Mon Mar 23 04:30:10 1998 +++ linux/drivers/sound/audio.c Mon Mar 23 04:37:23 1998 @@ -827,8 +827,15 @@ DMAbuf_launch_output(dev, dmap_out); } audio_devs[dev]->enable_bits = bits; +#if 0 + /* This call to the trigger function is the cause + for reversed stereo on some sound cards + (SoundBlaster). Sound and DMA is already + active and it will just cause the sound card to + lose sync with the DMA. Itai */ if (changed && audio_devs[dev]->d->trigger) audio_devs[dev]->d->trigger(dev, bits * audio_devs[dev]->go); +#endif restore_flags(flags); /* Falls through... */ | |