Messages in this thread | | | Date | Wed, 20 Nov 1996 11:25:15 -0800 (PST) | From | Trevor Johnson <> | Subject | Re: fix for the module problems in 2.1.11 |
| |
On Wed, 20 Nov 1996, Heiko Eissfeldt wrote:
> In case there is anybody left, who will accept modules related > patches from me (blush): > > --- module.c~ Tue Nov 19 16:03:38 1996 > +++ module.c Wed Nov 20 00:08:39 1996 > @@ -85,7 +85,7 @@ > is too long, but that we couldn't detect real faults then. > Maybe strncpy_from_user() should return -EBIG, when > the source string is too long. */ > - return strncpy_from_user(buf, user_name, MOD_MAX_NAME); > + return strncpy_from_user(buf, user_name, MOD_MAX_NAME) == -EFAULT ? -E2BIG : 0; > }
After applying this and leaving in place the changes provided by David S. Miller (Message-Id: <199611191322.IAA04915@jenolan.caipgeneral> in this same thread), the ppp, slhc, aha1542, st, scsi_mod, msdos, fat and sound modules--all the ones I've tried--work, the lp, floppy and 3c509 modules load without errors, and "depmod -a" gives no errors. I'm using an Am5x86-P75 CPU.
~> uname -a Linux ppp9.csudh.EDU 2.1.11 #3 Wed Nov 20 10:55:51 PST 1996 i486
~> lsmod Module: #pages: Used by: ppp 6 1 (autoclean) slhc 2 [ppp] 1 (autoclean) aha1542 3 1 st 7 1 (autoclean) scsi_mod 11 [aha1542 st] 2 (autoclean) 3c509 2 0 floppy 13 0 lp 2 0 msdos 2 1 (autoclean) fat 7 [msdos] 1 (autoclean) ___ Trevor Johnson <trevor@jpj.org>
| |