lkml.org 
[lkml]   [2024]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/1] isofs: Use *-y instead of *-objs in Makefile
On Wed 08-05-24 18:21:11, Andy Shevchenko wrote:
> *-objs suffix is reserved rather for (user-space) host programs while
> usually *-y suffix is used for kernel drivers (although *-objs works
> for that purpose for now).
>
> Let's correct the old usages of *-objs in Makefiles.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thanks! Added to my tree.

Honza

> ---
>
> Note, the original approach is weirdest from the existing.
> Only a few drivers use this (-objs-y) one most likely by mistake.
>
> fs/isofs/Makefile | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/fs/isofs/Makefile b/fs/isofs/Makefile
> index 6498fd2b0f60..b25bc542a22b 100644
> --- a/fs/isofs/Makefile
> +++ b/fs/isofs/Makefile
> @@ -5,7 +5,6 @@
>
> obj-$(CONFIG_ISO9660_FS) += isofs.o
>
> -isofs-objs-y := namei.o inode.o dir.o util.o rock.o export.o
> -isofs-objs-$(CONFIG_JOLIET) += joliet.o
> -isofs-objs-$(CONFIG_ZISOFS) += compress.o
> -isofs-objs := $(isofs-objs-y)
> +isofs-y := namei.o inode.o dir.o util.o rock.o export.o
> +isofs-$(CONFIG_JOLIET) += joliet.o
> +isofs-$(CONFIG_ZISOFS) += compress.o
> --
> 2.43.0.rc1.1336.g36b5255a03ac
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR

\
 
 \ /
  Last update: 2024-05-09 18:11    [W:0.022 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site