Messages in this thread | | | Date | Thu, 9 May 2024 10:16:10 +0200 | From | Luca Ceresoli <> | Subject | Re: [PATCH 1/3] scripts/decode_stacktrace.sh: remove find_module recursion and improve error reporting |
| |
Hello Stephen,
On Wed, 8 May 2024 17:35:53 -0400 Stephen Boyd <swboyd@chromium.org> wrote:
> Quoting Luca Ceresoli (2024-03-11 08:24:54) > > The find_module() function can fail for two reasons: > > > > * the module was not found > > * the module was found but without debugging info > > > > In both cases the user is reported the same error: > > > > WARNING! Modules path isn't set, but is needed to parse this symbol > > > > This is misleading in case the modules path is set correctly. > > > > find_module() is currently implemented as a recursive function based on > > global variables in order to check up to 4 different paths. This is not > > straightforward to read and even less to modify. > > > > Besides, the debuginfod code at the beginning of find_module() is executed > > identlcally every time the function is entered, i.e. up to 4 times per each > > s/identlcally/identically/
Well spotted!
Thanks for reviewing, v2 on its way.
Luca
-- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
| |