Messages in this thread | | | From | Stephen Boyd <> | Date | Wed, 8 May 2024 17:37:53 -0400 | Subject | Re: [PATCH 2/3] scripts/decode_stacktrace.sh: clarify command line |
| |
Quoting Luca Ceresoli (2024-03-11 08:24:55) > The syntax as expressed by usage() is not entirely correct: "<modules > path>" cannot be passed without "<base path>|auto". Additionally human > reading of this syntax can be subject to misunderstanding due the mixture > of '|' and '[]'. > > Improve readability in various ways: > * rewrite using two lines for the two allowed usages > * add square brackets around "<vmlinux>" as it is optional when using > debuginfod-find > * move "<modules path>" to inside the square brackets of the 2nd > positional parameter > * use underscores instead of spaces in <...> strings > > Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> > ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
| |