Messages in this thread | | | From | <> | Subject | Re: [PATCH net-next v1 3/3] net: dsa: microchip: dcb: set default apptrust to PCP only | Date | Wed, 8 May 2024 15:11:24 +0000 |
| |
Hi Oleksij,
On Wed, 2024-05-08 at 12:39 +0200, Oleksij Rempel wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > > -static const u8 ksz8_port2_supported_apptrust[] = { > - DCB_APP_SEL_PCP, > -}; > - > static const char * const ksz_supported_apptrust_variants[] = { > "empty", "dscp", "pcp", "dscp pcp" > }; > @@ -771,9 +767,8 @@ int ksz_port_get_apptrust(struct dsa_switch *ds, > int port, u8 *sel, int *nsel) > */ > int ksz_dcb_init_port(struct ksz_device *dev, int port) > { > - const u8 *sel; > + const u8 ksz_default_apptrust[] = { DCB_APP_SEL_PCP }; > int ret, ipm; > - int sel_len; > > if (is_ksz8(dev)) { > ipm = ieee8021q_tt_to_tc(IEEE8021Q_TT_BE, > @@ -789,18 +784,8 @@ int ksz_dcb_init_port(struct ksz_device *dev, > int port) > if (ret) > return ret; > > - if (ksz_is_ksz88x3(dev) && port == KSZ_PORT_2) { > - /* KSZ88x3 devices do not support DSCP classification > on > - * "Port 2. > - */ > - sel = ksz8_port2_supported_apptrust; > - sel_len = ARRAY_SIZE(ksz8_port2_supported_apptrust);
If we remove this, How the user application knows about the DSCP resistriction of KSZ8 port 2. Is it implemented in other functions?
> - } else { > - sel = ksz_supported_apptrust; > - sel_len = ARRAY_SIZE(ksz_supported_apptrust); > - } > - > - return ksz_port_set_apptrust(dev->ds, port, sel, sel_len); > + return ksz_port_set_apptrust(dev->ds, port, > ksz_default_apptrust, > + ARRAY_SIZE(ksz_default_apptrust) > ); > } > > /** > -- > 2.39.2 >
| |