Messages in this thread | | | From | <> | Subject | Re: [PATCH net-next v1 1/3] net: dsa: microchip: dcb: add comments for DSCP related functions | Date | Wed, 8 May 2024 14:58:42 +0000 |
| |
Hi Oleksij, On Wed, 2024-05-08 at 12:39 +0200, Oleksij Rempel wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > All other functions are commented. Add missing comments to following > functions: > ksz_set_global_dscp_entry() > ksz_port_add_dscp_prio() > ksz_port_del_dscp_prio() > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > drivers/net/dsa/microchip/ksz_dcb.c | 33 > ++++++++++++++++++++++++++++- > 1 file changed, 32 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/microchip/ksz_dcb.c > b/drivers/net/dsa/microchip/ksz_dcb.c > index 5e520c02afd72..879471cf815e3 100644 > --- a/drivers/net/dsa/microchip/ksz_dcb.c > +++ b/drivers/net/dsa/microchip/ksz_dcb.c > @@ -310,7 +310,18 @@ int ksz_port_get_dscp_prio(struct dsa_switch > *ds, int port, u8 dscp) > return (data >> shift) & mask; > } > > -static int ksz_set_global_dscp_entry(struct ksz_device *dev, u8 > dscp, u8 ipv)
nitpick: Whether adding comments should be last patch of series, since in this patch you are renaming parameter also from ipv to ipm.
Otherwise: Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com>
| |