lkml.org 
[lkml]   [2024]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next 5/5] gve: Add flow steering ethtool support
From

> +++ b/drivers/net/ethernet/google/gve/gve_ethtool.c

> +static int gve_get_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *cmd, u32 *rule_locs)
> +{
> + struct gve_priv *priv = netdev_priv(netdev);
> + int err = 0;
> +
> + dev_hold(netdev);
> + rtnl_unlock();

> +out:
> + rtnl_lock();
> + dev_put(netdev);
> + return err;
> +}


How do you think about to increase the application of scope-based resource management
at such source code places?

Regards,
Markus

\
 
 \ /
  Last update: 2024-05-08 16:09    [W:0.207 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site