Messages in this thread | | | From | Ziwei Xiao <> | Date | Thu, 9 May 2024 17:17:46 -0700 | Subject | Re: [PATCH net-next 2/5] gve: Add adminq extended command |
| |
On Tue, May 7, 2024 at 10:34 PM David Wei <dw@davidwei.uk> wrote: > > On 2024-05-07 15:59, Ziwei Xiao wrote: > > From: Jeroen de Borst <jeroendb@google.com> > > > > Add a new device option to signal to the driver that the device supports > > flow steering. This device option also carries the maximum number of > > flow steering rules that the device can store. > > Other than superficial style choices, looks good. > > > > > Signed-off-by: Jeroen de Borst <jeroendb@google.com> > > Co-developed-by: Ziwei Xiao <ziweixiao@google.com> > > Signed-off-by: Ziwei Xiao <ziweixiao@google.com> > > Reviewed-by: Praveen Kaligineedi <pkaligineedi@google.com> > > Reviewed-by: Harshitha Ramamurthy <hramamurthy@google.com> > > Reviewed-by: Willem de Bruijn <willemb@google.com> > > --- > > drivers/net/ethernet/google/gve/gve.h | 2 + > > drivers/net/ethernet/google/gve/gve_adminq.c | 42 ++++++++++++++++++-- > > drivers/net/ethernet/google/gve/gve_adminq.h | 11 +++++ > > 3 files changed, 51 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/ethernet/google/gve/gve.h b/drivers/net/ethernet/google/gve/gve.h > > index ca7fce17f2c0..58213c15e084 100644 > > --- a/drivers/net/ethernet/google/gve/gve.h > > +++ b/drivers/net/ethernet/google/gve/gve.h > > @@ -786,6 +786,8 @@ struct gve_priv { > > > > u16 header_buf_size; /* device configured, header-split supported if non-zero */ > > bool header_split_enabled; /* True if the header split is enabled by the user */ > > + > > + u32 max_flow_rules; > > nit: this struct is lovingly documented, could we continue by adding a > one liner here maybe about how it's device configured? > Will add.
> > }; > > > > enum gve_service_task_flags_bit { > > diff --git a/drivers/net/ethernet/google/gve/gve_adminq.c b/drivers/net/ethernet/google/gve/gve_adminq.c > > index 514641b3ccc7..85d0d742ad21 100644 > > --- a/drivers/net/ethernet/google/gve/gve_adminq.c > > +++ b/drivers/net/ethernet/google/gve/gve_adminq.c > > @@ -44,6 +44,7 @@ void gve_parse_device_option(struct gve_priv *priv, > > struct gve_device_option_jumbo_frames **dev_op_jumbo_frames, > > struct gve_device_option_dqo_qpl **dev_op_dqo_qpl, > > struct gve_device_option_buffer_sizes **dev_op_buffer_sizes, > > + struct gve_device_option_flow_steering **dev_op_flow_steering, > > nit: getting unwieldy here, is it time to pack into a struct? Thank you for pointing this out! We have plans to improve this device option part, but may not be able to be included in this patch.
| |