Messages in this thread Patch in this message | | | From | Breno Leitao <> | Subject | [PATCH] perf list: Fix the --no-desc option | Date | Wed, 8 May 2024 06:35:17 -0700 |
| |
Currently, the --no-desc option in perf list isn't functioning as intended.
This issue arises from the overwriting of struct option->desc with the opposite value of struct option->long_desc. Consequently, whatever parse_options() returns at struct option->desc gets overridden later, rendering the --desc or --no-desc arguments ineffective.
To resolve this, set ->desc as true by default and allow parse_options() to adjust it accordingly. This adjustment will fix the --no-desc option while preserving the functionality of the other parameters.
Signed-off-by: Breno Leitao <leitao@debian.org> --- tools/perf/builtin-list.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c index 02bf608d585e..58589f67e800 100644 --- a/tools/perf/builtin-list.c +++ b/tools/perf/builtin-list.c @@ -491,6 +491,7 @@ int cmd_list(int argc, const char **argv) int i, ret = 0; struct print_state default_ps = { .fp = stdout, + .desc = true, }; struct print_state json_ps = { .fp = stdout, @@ -563,7 +564,6 @@ int cmd_list(int argc, const char **argv) }; ps = &json_ps; } else { - default_ps.desc = !default_ps.long_desc; default_ps.last_topic = strdup(""); assert(default_ps.last_topic); default_ps.visited_metrics = strlist__new(NULL, NULL); -- 2.43.0
| |