Messages in this thread | | | Date | Wed, 8 May 2024 18:18:06 +0530 | Subject | Re: [PATCH 3/3] arm64: dts: ti: k3-j722s-evm: Update USB0 and USB1 configuration for EVM | From | Ravi Gunasekaran <> |
| |
On 5/8/24 5:33 PM, Roger Quadros wrote: > > > On 29/04/2024 15:09, Ravi Gunasekaran wrote: >> The GPIO expander on the EVM allows the USB selection for Type-C >> port to either USB0 or USB1 via USB hub. By default, let the Type-C >> port select USB0 via the GPIO expander port P05. >> >> Enable super-speed on USB1 by updating SerDes0 lane configuration. >> >> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> >> --- >> arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 58 +++++++++++++++++++++++++ >> arch/arm64/boot/dts/ti/k3-serdes.h | 7 +++ >> 2 files changed, 65 insertions(+) >>
[...]
>> + >> + p05-hog { >> + /* P05 - USB2.0_MUX_SEL */ >> + gpio-hog; >> + gpios = <5 GPIO_ACTIVE_LOW>; >> + output-high; >> + line-name = "USB2.0_MUX_SEL"; > > This line-name is already added in gpio-line-names property above. > Do we really need to add it again?
Not needed. If the line-name property is not present for the hog, then its taken from the gpio chip via gpio-line-names. So I will remove the line-name property in v2
static struct gpio_desc *of_parse_own_gpio(...) .. if (name && of_property_read_string(np, "line-name", name)) *name = np->name; ..
> >> + }; >> }; >> }; >>
[...]
-- Regards, Ravi
| |