Messages in this thread | | | Date | Wed, 08 May 2024 14:34:07 +0200 | From | Takashi Iwai <> | Subject | Re: [PATCH] ALSA: hda: hda_component: Initialize shared data during bind callback |
| |
On Wed, 08 May 2024 12:03:47 +0200, Richard Fitzgerald wrote: > > Move the initialization of the shared struct hda_component array into > hda_component_manager_bind(). > > The purpose of the manager bind() callback is to allow it to perform > initialization before binding in the component drivers. This is the > correct place to initialize the shared data. > > The original implementation initialized the shared data in > hda_component_manager_init(). This is only done once during probe() > of the manager driver. So if the component binding was unbound and > then rebound, the shared data would not be re-initialized. > > Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com> > Fixes: fd895a74dc1d ("ALSA: hda: realtek: Move hda_component implementation to module")
Applied now. Thanks.
Takashi
| |