| From | Linus Walleij <> | Date | Tue, 16 Apr 2024 15:07:09 +0200 | Subject | Re: [PATCH 4/6] pinctrl: bcm: Add pinconf/pinmux controller driver for BCM2712 |
| |
Hi Andrea,
thanks for your patch!
Some comments apart from was said already.
On Sun, Apr 14, 2024 at 12:14 AM Andrea della Porta <andrea.porta@suse.com> wrote:
> +#include <linux/pinctrl/consumer.h> > +#include <linux/pinctrl/machine.h>
Really? Why?
> +#include <linux/pinctrl/pinconf.h> > +#include <linux/pinctrl/pinctrl.h> > +#include <linux/pinctrl/pinmux.h> > +#include <linux/pinctrl/pinconf-generic.h>
I would just expect these.
> +static int bcm2712_pinctrl_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + //struct device_node *np = dev->of_node; > + const struct bcm_plat_data *pdata; > + //const struct of_device_id *match;
I don't know if others commented on it but drop all commented-out code or make use of it.
Yours, Linus Walleij
|