Messages in this thread | | | Date | Mon, 7 Dec 2020 00:48:02 +0200 | From | Laurent Pinchart <> | Subject | Re: [PATCH 06/12] arm64: dts: zynqmp: Add label for zynqmp_ipi |
| |
On Mon, Dec 07, 2020 at 12:46:56AM +0200, Laurent Pinchart wrote: > Hi Michal, > > Thank you for the patch. > > On Wed, Dec 02, 2020 at 03:06:05PM +0100, Michal Simek wrote: > > Add label which is used by bootloader for adding bootloader specific flag. > > > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > > --- > > > > U-Boot needs to add u-boot,dm-pre-reloc; property > > I'm not entirely sure what best practice rules are in this area, but > shouldn't U-Boot locate the node by name instead of label ?
And regardless of what mechanism is used, it should be documented in the bindings.
> > --- > > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > > index 4fa820f78d76..8e9b54b5e70c 100644 > > --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > > +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > > @@ -99,7 +99,7 @@ opp03 { > > }; > > }; > > > > - zynqmp_ipi { > > + zynqmp_ipi: zynqmp_ipi { > > compatible = "xlnx,zynqmp-ipi-mailbox"; > > interrupt-parent = <&gic>; > > interrupts = <0 35 4>;
-- Regards,
Laurent Pinchart
| |