lkml.org 
[lkml]   [2020]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 06/12] arm64: dts: zynqmp: Add label for zynqmp_ipi
    Hi Michal,

    Thank you for the patch.

    On Wed, Dec 02, 2020 at 03:06:05PM +0100, Michal Simek wrote:
    > Add label which is used by bootloader for adding bootloader specific flag.
    >
    > Signed-off-by: Michal Simek <michal.simek@xilinx.com>
    > ---
    >
    > U-Boot needs to add u-boot,dm-pre-reloc; property

    I'm not entirely sure what best practice rules are in this area, but
    shouldn't U-Boot locate the node by name instead of label ?

    > ---
    > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
    > index 4fa820f78d76..8e9b54b5e70c 100644
    > --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
    > +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
    > @@ -99,7 +99,7 @@ opp03 {
    > };
    > };
    >
    > - zynqmp_ipi {
    > + zynqmp_ipi: zynqmp_ipi {
    > compatible = "xlnx,zynqmp-ipi-mailbox";
    > interrupt-parent = <&gic>;
    > interrupts = <0 35 4>;

    --
    Regards,

    Laurent Pinchart

    \
     
     \ /
      Last update: 2020-12-06 23:48    [W:2.524 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site