Messages in this thread Patch in this message | | | From | Arnd Bergmann <> | Subject | [PATCH] crypto: aegis128 - fix link error without SIMD | Date | Thu, 3 Dec 2020 23:25:49 +0100 |
| |
From: Arnd Bergmann <arnd@arndb.de>
When the SIMD portion of the driver is disabled, the compiler cannot figure out in advance if it will be called:
ERROR: modpost: "crypto_aegis128_update_simd" [crypto/aegis128.ko] undefined!
Add a conditional to let the compiler use dead code elimination as before.
Fixes: ac50aec41a9f ("crypto: aegis128 - expose SIMD code path as separate driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- crypto/aegis128-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/crypto/aegis128-core.c b/crypto/aegis128-core.c index 2b05f79475d3..89dc1c559689 100644 --- a/crypto/aegis128-core.c +++ b/crypto/aegis128-core.c @@ -89,7 +89,7 @@ static void crypto_aegis128_update_a(struct aegis_state *state, const union aegis_block *msg, bool do_simd) { - if (do_simd) { + if (IS_ENABLED(CONFIG_CRYPTO_AEGIS128_SIMD) && do_simd) { crypto_aegis128_update_simd(state, msg); return; } @@ -101,7 +101,7 @@ static void crypto_aegis128_update_a(struct aegis_state *state, static void crypto_aegis128_update_u(struct aegis_state *state, const void *msg, bool do_simd) { - if (do_simd) { + if (IS_ENABLED(CONFIG_CRYPTO_AEGIS128_SIMD) && do_simd) { crypto_aegis128_update_simd(state, msg); return; } -- 2.27.0
| |