Messages in this thread Patch in this message | | | From | Adrian Huang <> | Subject | [PATCH 1/1] x86/mm: Refine mmap syscall implementation | Date | Thu, 17 Dec 2020 13:26:48 +0800 |
| |
From: Adrian Huang <ahuang12@lenovo.com>
It is unnecessary to use the local variable 'error' in the mmap syscall implementation function, so use the return statement instead of it.
Signed-off-by: Adrian Huang <ahuang12@lenovo.com> --- arch/x86/kernel/sys_x86_64.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kernel/sys_x86_64.c b/arch/x86/kernel/sys_x86_64.c index 504fa5425bce..660b78827638 100644 --- a/arch/x86/kernel/sys_x86_64.c +++ b/arch/x86/kernel/sys_x86_64.c @@ -90,14 +90,10 @@ SYSCALL_DEFINE6(mmap, unsigned long, addr, unsigned long, len, unsigned long, prot, unsigned long, flags, unsigned long, fd, unsigned long, off) { - long error; - error = -EINVAL; if (off & ~PAGE_MASK) - goto out; + return -EINVAL; - error = ksys_mmap_pgoff(addr, len, prot, flags, fd, off >> PAGE_SHIFT); -out: - return error; + return ksys_mmap_pgoff(addr, len, prot, flags, fd, off >> PAGE_SHIFT); } static void find_start_end(unsigned long addr, unsigned long flags, -- 2.17.1
| |