lkml.org 
[lkml]   [2020]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] sata_fsl: Fix a resource leak in an error handling path in the probe function
Date
'irq_dispose_mapping()' should be called in the error handling path of the
probe function, as already done in the remove function.

Fixes: 6b4b8fc87dc5 ("sata_fsl: add support for interrupt coalsecing feature")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/ata/sata_fsl.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index d55ee244d693..49ecbc55a804 100644
--- a/drivers/ata/sata_fsl.c
+++ b/drivers/ata/sata_fsl.c
@@ -1540,6 +1540,9 @@ static int sata_fsl_probe(struct platform_device *ofdev)
if (host)
ata_host_detach(host);

+ if (host_priv && host_priv->irq)
+ irq_dispose_mapping(host_priv->irq);
+
if (hcr_base)
iounmap(hcr_base);
kfree(host_priv);
--
2.27.0
\
 
 \ /
  Last update: 2020-12-12 14:02    [W:0.021 / U:1.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site