Messages in this thread Patches in this message | | | Date | Sun, 24 Dec 2006 09:51:50 -0600 | From | Larry Finger <> | Subject | bcm43xx-softmac broken on 2.6.20-rc2 |
| |
This is a heads-up for anyone wishing to use bcm43xx-softmac on Linus's git tree, which is now at v2.6.20-rc2. There are two serious bugs in that code. Fixes are found below.
The first bug is the result of changes in work queues. The second is the result of a typo that locks a mutex when it should unlock it.
These fixes have been pushed up stream, but neither has made it to Linus.
Larry ---
diff --git a/net/ieee80211/softmac/ieee80211softmac_assoc.c b/net/ieee80211/softmac/ieee80211softmac_assoc.c index eec1a1d..a824852 100644 --- a/net/ieee80211/softmac/ieee80211softmac_assoc.c +++ b/net/ieee80211/softmac/ieee80211softmac_assoc.c @@ -167,7 +167,7 @@ static void ieee80211softmac_assoc_notify_scan(struct net_device *dev, int event_type, void *context) { struct ieee80211softmac_device *mac = ieee80211_priv(dev); - ieee80211softmac_assoc_work((void*)mac); + ieee80211softmac_assoc_work(&mac->associnfo.work.work); }
static void @@ -177,7 +177,7 @@ ieee80211softmac_assoc_notify_auth(struc
switch (event_type) { case IEEE80211SOFTMAC_EVENT_AUTHENTICATED: - ieee80211softmac_assoc_work((void*)mac); + ieee80211softmac_assoc_work(&mac->associnfo.work.work); break; case IEEE80211SOFTMAC_EVENT_AUTH_FAILED: case IEEE80211SOFTMAC_EVENT_AUTH_TIMEOUT:
Index: linux-2.6/net/ieee80211/softmac/ieee80211softmac_wx.c =================================================================== --- linux-2.6.orig/net/ieee80211/softmac/ieee80211softmac_wx.c +++ linux-2.6/net/ieee80211/softmac/ieee80211softmac_wx.c @@ -463,7 +463,7 @@ ieee80211softmac_wx_get_genie(struct net err = -E2BIG; } spin_unlock_irqrestore(&mac->lock, flags); - mutex_lock(&mac->associnfo.mutex); + mutex_unlock(&mac->associnfo.mutex);
return err; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |